replicatedhq/kURL #6211

Completed in 3m 57s · Queued 5s · Ran 3m 52s

View pull request

Findings

Review findings and their code anchors.

2 findings

If you have the time (2)

Behavioral fetch.py change ships under a 'docs-only, no code' declaration

Detected by review/code

Finding ID: candidate-1

.claude/skills/testgrid-failure-analysis/fetch.py:111 View GitHub comment

109        and not i.get("isUnsupported")
110        and not i.get("isSkipped")
111        and not i.get("cancelledAt")  # cancelled instances are not failures
112        and i.get("finishedAt")
113    ]
114

Line 111 changes fetch.py behavior, but the PR claims docs-only. List the filter change in the PR body or split it out, and confirm the field name against a live API response before merge.

Resolve conversation on GitHub

cancelledAt exclusion filter has no documented API contract and may be a silent no-op

Detected by review/code

Finding ID: candidate-2

.claude/skills/testgrid-failure-analysis/fetch.py:111 View GitHub comment

109        and not i.get("isUnsupported")
110        and not i.get("isSkipped")
111        and not i.get("cancelledAt")  # cancelled instances are not failures
112        and i.get("finishedAt")
113    ]
114

The `cancelledAt` exclusion filter relies on undocumented API behavior — if the API doesn't guarantee that semantics, this silently filters nothing. Verify against the actual API contract or add a test proving the exclusion works; otherwise drop the filter.

Resolve conversation on GitHub