Go Observability adversary

Reviews Go logs, traces, metrics, context propagation, and telemetry lifecycle defects.

Goals

The adversary is designed to produce a small number of high-confidence, actionable findings grounded in concrete repository evidence. Its review should be deterministic where possible, explicit about impact, and quiet when the available evidence does not justify a finding.

Scope

It evaluates changed Go logging, metrics, tracing, and panic-recovery code for signal correctness, cardinality, lifecycle, and context propagation. The narrow missing-diagnostic exception is a proven parser failure that changed code deliberately collapses into a sentinel while discarding the cause despite an established context logger; it does not ask for logs merely because a branch can fail.

The complete detector or review inventory is maintained in CHECKS.md.

Boundaries

It owns only this Go specialty. Other Go concerns remain with the corresponding go/* adversaries, and it does not execute or modify the target repository.

SDK source coverage

This release uses SDK 0.1.43. This reviewer uses deterministic prepared evidence rather than repository-tool model retrieval, so it has no model coverage result to reinterpret. Existing evidence gates and deterministic findings are preserved.

SDK 0.1.43

This release rebuilds with SDK 0.1.43. SDK PR #73 adds a tested neutral fallback to formatOpinionAsync when concern wording validation is exhausted, preserving completed findings and the ship decision. Reviewers that do not call this API retain their existing opinion behavior. Provider and transport failures remain errors. Domain rules and evidence requirements are unchanged.